Ensure 'run_tests.sh local' fails correctly when gometalinter errors. #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a clean install, gometalinter can return non-zero, or gometalinter
may not run at all if it is not present.
In these cases, the content of stdout is zero bytes, and the script
continues when it should error out.
This error can easily occur when initially setting up the dev project
and one has not installed gometalinter or unconvert. (This is not
a problem for docker testing, as these are preinstalled.)
Also updated README.md to describe the testing dependencies.