rpcserver: return rule error on rejected raw tx #808
Conversation
There was a problem hiding this comment.
This will need some changes.
First off, the comment above is now wrong because it talks about how it is not returning a deserialization error, yet now it does.
Second, this is not the behavior we really want, even if this is what bitcoind does (or did at time of comment). What we do want is to use an error code that specifies that the input was rejected due to either consensus or policy rules. Unfortunately, no such error code exists at this time. I think we should cross reference bitcoind to see if they have added anything to handle this and if so use it, otherwise we can add our own error code.
Finally, the first line of the commit message makes no sense. This change does not touch the wire package at all, and instead only affects the JSON-RPC server.
dnldd
force-pushed
the
sendrawtransaction
branch
from
ca5b125 to
f0c21a0
Compare
dnldd
changed the title
dnldd
force-pushed
the
sendrawtransaction
branch
from
f0c21a0 to
5f04432
Compare
dnldd
changed the title
|
I've cross referenced with bitcoind and it's also using the deserialization error type for the rule error case. Now using |
rpcserver.go
Outdated
| } else { | ||
| rpcsLog.Errorf("Failed to process transaction %v: %v", | ||
| tx.Hash(), err) | ||
| rpcsLog.Debugf(err.Error(), "") |
There was a problem hiding this comment.
All of these should use "%v" or "%s" as the format string, not the error string.
dnldd
force-pushed
the
sendrawtransaction
branch
from
5f04432 to
8bbe65e
Compare
|
@jrick updated the PR per your review. |
dnldd
force-pushed
the
sendrawtransaction
branch
from
8bbe65e to
4438181
Compare
Closes #733