[release-v2.0] main: Use backported addrmgr updates. #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subtracting an unset time.Time value yields a large number, resulting in a chance value of 1, and will never be less than the random value.
This updates the 2.0 release branch to use the latest version of the addrmgr module which includes an update to give unattempted addresses a chance at being selected. In particular, the following updated module version is used: - github.com/decred/dcrd/addrmgr/[email protected]
jrick
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the 2.0 release branch to use the latest version of the
addrmgrmodule which includes an update to give unattempted addresses a chance at being selected.In particular, the following updated module version is used:
Note that it also cherry picks all of the commits included in updates to the
addrmgr/v2module to ensure they are also included in the release branch even though it is not strictly necessary sincego.modhas been updated to require the newaddrmgr/v2.0.4release and thus will pull in the new code. However, from past experience, not having code backported to modules available in the release branch too leads to headaches for devs building from source in their local workspace with overrides such as those ingo.work.