config: Show usage message on invalid cli flags. #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the error handling code was not matching the intended behaviour described in its comment, and as a result the usage message was not being displayed when an invalid config flag was passed. dcrd was also exiting with code 0 instead of 1. After fixing this bug the usage message was shown as expected and the exit code was correct, but the config error was being printed twice - once by dcrd itself, and once by the go-flags lib. This was fixed by changing the options passed into go-flags.
davecgh
approved these changes
May 16, 2024
davecgh
added
cli flag change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the error handling code was not matching the intended behaviour described in its comment, and as a result the usage message was not being displayed when an invalid config flag was passed. dcrd was also exiting with code 0 instead of 1.
After fixing this bug the usage message was shown as expected and the exit code was correct, but the config error was being printed twice - once by dcrd itself, and once by the go-flags lib. This was fixed by changing the options passed into go-flags.