Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire: Add MsgMixFactoredPoly #3247

Merged
merged 1 commit into from
May 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 35 additions & 31 deletions wire/message.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,37 +28,38 @@ const MaxMessagePayload = (1024 * 1024 * 32) // 32MB

// Commands used in message headers which describe the type of message.
const (
CmdVersion = "version"
CmdVerAck = "verack"
CmdGetAddr = "getaddr"
CmdAddr = "addr"
CmdGetBlocks = "getblocks"
CmdInv = "inv"
CmdGetData = "getdata"
CmdNotFound = "notfound"
CmdBlock = "block"
CmdTx = "tx"
CmdGetHeaders = "getheaders"
CmdHeaders = "headers"
CmdPing = "ping"
CmdPong = "pong"
CmdMemPool = "mempool"
CmdMiningState = "miningstate"
CmdGetMiningState = "getminings"
CmdReject = "reject"
CmdSendHeaders = "sendheaders"
CmdFeeFilter = "feefilter"
CmdGetCFilterV2 = "getcfilterv2"
CmdCFilterV2 = "cfilterv2"
CmdGetInitState = "getinitstate"
CmdInitState = "initstate"
CmdMixPairReq = "mixpairreq"
CmdMixKeyExchange = "mixkeyxchg"
CmdMixCiphertexts = "mixcphrtxt"
CmdMixSlotReserve = "mixslotres"
CmdMixDCNet = "mixdcnet"
CmdMixConfirm = "mixconfirm"
CmdMixSecrets = "mixsecrets"
CmdVersion = "version"
CmdVerAck = "verack"
CmdGetAddr = "getaddr"
CmdAddr = "addr"
CmdGetBlocks = "getblocks"
CmdInv = "inv"
CmdGetData = "getdata"
CmdNotFound = "notfound"
CmdBlock = "block"
CmdTx = "tx"
CmdGetHeaders = "getheaders"
CmdHeaders = "headers"
CmdPing = "ping"
CmdPong = "pong"
CmdMemPool = "mempool"
CmdMiningState = "miningstate"
CmdGetMiningState = "getminings"
CmdReject = "reject"
CmdSendHeaders = "sendheaders"
CmdFeeFilter = "feefilter"
CmdGetCFilterV2 = "getcfilterv2"
CmdCFilterV2 = "cfilterv2"
CmdGetInitState = "getinitstate"
CmdInitState = "initstate"
CmdMixPairReq = "mixpairreq"
CmdMixKeyExchange = "mixkeyxchg"
CmdMixCiphertexts = "mixcphrtxt"
CmdMixSlotReserve = "mixslotres"
CmdMixFactoredPoly = "mixfactpoly"
CmdMixDCNet = "mixdcnet"
CmdMixConfirm = "mixconfirm"
CmdMixSecrets = "mixsecrets"
)

const (
Expand Down Expand Up @@ -207,6 +208,9 @@ func makeEmptyMessage(command string) (Message, error) {
case CmdMixSlotReserve:
msg = &MsgMixSlotReserve{}

case CmdMixFactoredPoly:
msg = &MsgMixFactoredPoly{}

case CmdMixDCNet:
msg = &MsgMixDCNet{}

Expand Down
2 changes: 2 additions & 0 deletions wire/message_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ func TestMessage(t *testing.T) {
msgMixKE := NewMsgMixKeyExchange([33]byte{}, [32]byte{}, 1, 1, [33]byte{}, [1218]byte{}, [32]byte{}, []chainhash.Hash{})
msgMixCT := NewMsgMixCiphertexts([33]byte{}, [32]byte{}, 1, [][1047]byte{}, []chainhash.Hash{})
msgMixSR := NewMsgMixSlotReserve([33]byte{}, [32]byte{}, 1, [][][]byte{{{}}}, []chainhash.Hash{})
msgMixFP := NewMsgMixFactoredPoly([33]byte{}, [32]byte{}, 1, [][]byte{}, []chainhash.Hash{})
msgMixDC := NewMsgMixDCNet([33]byte{}, [32]byte{}, 1, []MixVect{make(MixVect, 1)}, []chainhash.Hash{})
msgMixCM := NewMsgMixConfirm([33]byte{}, [32]byte{}, 1, NewMsgTx(), []chainhash.Hash{})
msgMixRS := NewMsgMixSecrets([33]byte{}, [32]byte{}, 1, [32]byte{}, [][]byte{}, MixVect{})
Expand Down Expand Up @@ -126,6 +127,7 @@ func TestMessage(t *testing.T) {
{msgMixKE, msgMixKE, pver, MainNet, 1449},
{msgMixCT, msgMixCT, pver, MainNet, 158},
{msgMixSR, msgMixSR, pver, MainNet, 161},
{msgMixFP, msgMixFP, pver, MainNet, 159},
{msgMixDC, msgMixDC, pver, MainNet, 181},
{msgMixCM, msgMixCM, pver, MainNet, 173},
{msgMixRS, msgMixRS, pver, MainNet, 192},
Expand Down
2 changes: 1 addition & 1 deletion wire/msgmixdcnet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func TestMsgMixDCNetWire(t *testing.T) {
expected = append(expected, repeat(0x91, 20)...)
expected = append(expected, repeat(0x92, 20)...)
expected = append(expected, repeat(0x93, 20)...)
// Four seen DCs (repeating 32 bytes of 0x94, 0x95, 0x96, 0x97)
// Four seen SRs (repeating 32 bytes of 0x94, 0x95, 0x96, 0x97)
davecgh marked this conversation as resolved.
Show resolved Hide resolved
expected = append(expected, 0x04)
expected = append(expected, repeat(0x94, 32)...)
expected = append(expected, repeat(0x95, 32)...)
Expand Down
259 changes: 259 additions & 0 deletions wire/msgmixfactoredpoly.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,259 @@
// Copyright (c) 2024 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.

package wire

import (
"fmt"
"hash"
"io"

"github.com/decred/dcrd/chaincfg/chainhash"
)

// MsgMixFactoredPoly encodes the solution of the factored slot reservation
// polynomial.
type MsgMixFactoredPoly struct {
Signature [64]byte
Identity [33]byte
SessionID [32]byte
Run uint32
Roots [][]byte
SeenSlotReserves []chainhash.Hash

// hash records the hash of the message. It is a member of the
// message for convenience and performance, but is never automatically
// set during creation or deserialization.
hash chainhash.Hash
}

// BtcDecode decodes r using the Decred protocol encoding into the receiver.
// This is part of the Message interface implementation.
func (msg *MsgMixFactoredPoly) BtcDecode(r io.Reader, pver uint32) error {
const op = "MsgMixFactoredPoly.BtcDecode"
if pver < MixVersion {
msg := fmt.Sprintf("%s message invalid for protocol version %d",
msg.Command(), pver)
return messageError(op, ErrMsgInvalidForPVer, msg)
}

err := readElements(r, &msg.Signature, &msg.Identity, &msg.SessionID,
&msg.Run)
if err != nil {
return err
}

count, err := ReadVarInt(r, pver)
if err != nil {
return err
}
if count > MaxMixMcount {
msg := fmt.Sprintf("too many roots in message [count %v, max %v]",
count, MaxMixMcount)
return messageError(op, ErrInvalidMsg, msg)
}

roots := make([][]byte, count)
for i := range roots {
root, err := ReadVarBytes(r, pver, MaxMixFieldValLen, "MixFactoredPoly.Roots")
if err != nil {
return err
}
roots[i] = root
}
msg.Roots = roots

count, err = ReadVarInt(r, pver)
if err != nil {
return err
}
if count > MaxMixPeers {
msg := fmt.Sprintf("too many previous referenced messages [count %v, max %v]",
count, MaxMixPeers)
return messageError(op, ErrTooManyPrevMixMsgs, msg)
}

seen := make([]chainhash.Hash, count)
for i := range seen {
err := readElement(r, &seen[i])
if err != nil {
return err
}
}
msg.SeenSlotReserves = seen

return nil
}

// BtcEncode encodes the receiver to w using the Decred protocol encoding.
// This is part of the Message interface implementation.
func (msg *MsgMixFactoredPoly) BtcEncode(w io.Writer, pver uint32) error {
const op = "MsgMixFactoredPoly.BtcEncode"
if pver < MixVersion {
msg := fmt.Sprintf("%s message invalid for protocol version %d",
msg.Command(), pver)
return messageError(op, ErrMsgInvalidForPVer, msg)
}

err := writeElement(w, &msg.Signature)
if err != nil {
return err
}

err = msg.writeMessageNoSignature(op, w, pver)
if err != nil {
return err
}

return nil
}

// Hash returns the message hash calculated by WriteHash.
//
// Hash returns an invalid or zero hash if WriteHash has not been called yet.
//
// This method is not safe while concurrently calling WriteHash.
func (msg *MsgMixFactoredPoly) Hash() chainhash.Hash {
return msg.hash
}

// WriteHash serializes the message to a hasher and records the sum in the
// message's Hash field.
//
// The hasher's Size() must equal chainhash.HashSize, or this method will
// panic. This method is designed to work only with hashers returned by
// blake256.New.
func (msg *MsgMixFactoredPoly) WriteHash(h hash.Hash) {
h.Reset()
writeElement(h, &msg.Signature)
msg.writeMessageNoSignature("", h, MixVersion)
sum := h.Sum(msg.hash[:0])
if len(sum) != len(msg.hash) {
s := fmt.Sprintf("hasher type %T has invalid Size() for chainhash.Hash", h)
panic(s)
}
}

// writeMessageNoSignature serializes all elements of the message except for
// the signature. This allows code reuse between message serialization, and
// signing and verifying these message contents.
//
// If w implements hash.Hash, no errors will be returned for invalid message
// construction.
func (msg *MsgMixFactoredPoly) writeMessageNoSignature(op string, w io.Writer, pver uint32) error {
_, hashing := w.(hash.Hash)

count := len(msg.Roots)
if !hashing && count > MaxMixMcount {
msg := fmt.Sprintf("too many solutions to factored polynomial [count %v, max %v]",
count, MaxMixMcount)
return messageError(op, ErrInvalidMsg, msg)
}
for _, root := range msg.Roots {
if !hashing && len(root) > MaxMixFieldValLen {
msg := "root exceeds bytes necessary to represent number in field"
return messageError(op, ErrInvalidMsg, msg)
}
}
srcount := len(msg.SeenSlotReserves)
if !hashing && srcount > MaxMixPeers {
msg := fmt.Sprintf("too many previous referenced messages [count %v, max %v]",
srcount, MaxMixPeers)
return messageError(op, ErrTooManyPrevMixMsgs, msg)
}

err := writeElements(w, &msg.Identity, &msg.SessionID, msg.Run)
if err != nil {
return err
}

err = WriteVarInt(w, pver, uint64(count))
if err != nil {
return err
}
for _, root := range msg.Roots {
err := WriteVarBytes(w, pver, root)
if err != nil {
return err
}
}

err = WriteVarInt(w, pver, uint64(srcount))
if err != nil {
return err
}
for i := range msg.SeenSlotReserves {
err = writeElement(w, &msg.SeenSlotReserves[i])
if err != nil {
return err
}
}

return nil
}

// WriteSignedData writes a tag identifying the message data, followed by all
// message fields excluding the signature. This is the data committed to when
// the message is signed.
func (msg *MsgMixFactoredPoly) WriteSignedData(h hash.Hash) {
WriteVarString(h, MixVersion, CmdMixFactoredPoly+"-sig")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to hold up this PR since WriteVarString doesn't actually use the parameter currently anyway, but I have noticed in all of these that they're arguably misusing the protocol version. It is generally supposed to be passed in so that it ultimately is the negotiated protocol version. The intention of the parameter is that some future protocol version might change the semantics and thus it would need to selectively choose based on the negotiated version.

That said, I mentioned arguably previously because I guess you could argue that given this is a signature, you might want it to be stable. However, I don't believe there is anything long term that would need it to be stable in such a scenario.

msg.writeMessageNoSignature("", h, MixVersion)
}

// Command returns the protocol command string for the message. This is part
// of the Message interface implementation.
func (msg *MsgMixFactoredPoly) Command() string {
return CmdMixFactoredPoly
}

// MaxPayloadLength returns the maximum length the payload can be for the
// receiver. This is part of the Message interface implementation.
func (msg *MsgMixFactoredPoly) MaxPayloadLength(pver uint32) uint32 {
if pver < MixVersion {
return 0
}

// See tests for this calculation.
return 49291
}

// Pub returns the message sender's public key identity.
func (msg *MsgMixFactoredPoly) Pub() []byte {
return msg.Identity[:]
}

// Sig returns the message signature.
func (msg *MsgMixFactoredPoly) Sig() []byte {
return msg.Signature[:]
}

// PrevMsgs returns the previous SR messages seen by the peer.
func (msg *MsgMixFactoredPoly) PrevMsgs() []chainhash.Hash {
return msg.SeenSlotReserves
}

// Sid returns the session ID.
func (msg *MsgMixFactoredPoly) Sid() []byte {
return msg.SessionID[:]
}

// GetRun returns the run number.
func (msg *MsgMixFactoredPoly) GetRun() uint32 {
return msg.Run
}

// NewMsgMixFactoredPoly returns a new mixpairreq message that conforms to the
// Message interface using the passed parameters and defaults for the
// remaining fields.
func NewMsgMixFactoredPoly(identity [33]byte, sid [32]byte, run uint32,
roots [][]byte, seenSlotReserves []chainhash.Hash) *MsgMixFactoredPoly {

return &MsgMixFactoredPoly{
Identity: identity,
SessionID: sid,
Run: run,
Roots: roots,
SeenSlotReserves: seenSlotReserves,
}
}
Loading
Loading