Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire: Add MsgMixFactoredPoly #3247
wire: Add MsgMixFactoredPoly #3247
Changes from all commits
eb0bf48
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to hold up this PR since
WriteVarString
doesn't actually use the parameter currently anyway, but I have noticed in all of these that they're arguably misusing the protocol version. It is generally supposed to be passed in so that it ultimately is the negotiated protocol version. The intention of the parameter is that some future protocol version might change the semantics and thus it would need to selectively choose based on the negotiated version.That said, I mentioned arguably previously because I guess you could argue that given this is a signature, you might want it to be stable. However, I don't believe there is anything long term that would need it to be stable in such a scenario.