wire: add flag bits to PR message #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
May 9, 2024
Two new flag fields are introduced to the pair request message, both of which are application specific and have no meaning to the wire package. The first is a Flags field which will be used to describe capabilities that do not affect the pairing type. This will be used in the initial release to allow wallets to advertise support for solving and publishing the factored polynomial. While here, a second flags field which affects the pairing compatibility is also added, as this will aid in any future incompatibility in the client behavior without disturbing clients who have not upgraded.
davecgh
approved these changes
May 9, 2024
davecgh
added
the
wire protocol change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new flag fields are introduced to the pair request message, both of which are application specific and have no meaning to the wire package. The first is a Flags field which will be used to describe capabilities that do not affect the pairing type. This will be used in the initial release to allow wallets to advertise support for solving and publishing the factored polynomial. While here, a second flags field which affects the pairing compatibility is also added, as this will aid in any future incompatibility in the client behavior without disturbing clients who have not upgraded.