connmgr: Only mark persistent peer reconn pending. #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Apr 30, 2024
The current code is incorrectly treating non-persistent peer requests as though they will be reconnected to whenever the target number of outbound peers has not been reached by marking them as pending and logging the reconnection attempt that will never come. In addition to the spurious logging, it also means that manually attempting to reconnect to such a peer will incorrectly believe a connection is already pending. This resolves that issue by only logging the attempt and adding the connection request back to the pending map for persistent peers.
davecgh
force-pushed
the
connmgr_only_mark_persistent_peer_reconn_pending
branch
from
8724f58 to
02eaf5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is incorrectly treating non-persistent peer requests as though they will be reconnected to whenever the target number of outbound peers has not been reached by marking them as pending and logging the reconnection attempt that will never come. In addition to the spurious logging, it also means that manually attempting to reconnect to such a peer will incorrectly believe a connection is already pending.
This resolves that issue by only logging the attempt and adding the connection request back to the pending map for persistent peers.