rpcserver: Remove unneeded AddedNodeInfo method. #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Apr 30, 2024
davecgh
force-pushed
the
rpcserver_added_node_to_persistent_peers
branch
from
29e11bd to
13c49c1
Compare
The RPC server was refactored some time ago to decouple it from the internals of the main server and part of that refactoring modified the RPC server to make use of a local peer interface to obtain all necessary information about peers which is then used to create RPC server results. Due to that, the AddedNodeInfo and PersistentPeers methods now do the exact same thing. This modifies the rpcserver.ConnManager interface to remove the now unnecessary AddedNodeInfo method in favor of the PersistentPeers method and updates all relevant code accordingly.
davecgh
force-pushed
the
rpcserver_added_node_to_persistent_peers
branch
from
13c49c1 to
8385f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC server was refactored some time ago to decouple it from the internals of the main server and part of that refactoring modified the RPC server to make use of a local peer interface to obtain all necessary information about peers which is then used to create RPC server results. Due to that, the
AddedNodeInfoandPersistentPeersmethods now do the exact same thing.This modifies the
rpcserver.ConnManagerinterface to remove the now unnecessaryAddedNodeInfomethod in favor of thePersistentPeersmethod and updates all relevant code accordingly.