Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secp256k1/ecdsa: Add tests for new R and S methods. #3190

Merged
merged 1 commit into from
Sep 21, 2023
Merged

secp256k1/ecdsa: Add tests for new R and S methods. #3190

merged 1 commit into from
Sep 21, 2023

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Sep 21, 2023

This adds a couple of additional checks to the sign and verify tests to ensure the new R and S methods return the expected values.

Test coverage before:

$ go test -cover
PASS
coverage: 98.3% of statements

Test coverage after:

$ go test -cover
coverage: 99.2% of statements

@davecgh davecgh added this to the 1.9.0 milestone Sep 21, 2023
@davecgh davecgh mentioned this pull request Sep 21, 2023
Merged
@davecgh davecgh added the test coverage Discussion and pull requests for improving test coverage. label Sep 21, 2023
@davecgh
secp256k1/ecdsa: Add tests for new R and S methods.
9754217 
This adds a couple of additional checks to the sign and verify tests to
ensure the new R and S methods return the expected values.
@davecgh davecgh merged commit 9754217 into decred:master Sep 21, 2023
@davecgh davecgh deleted the ecdsa_r_s_tests branch September 21, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jholdstock jholdstock jholdstock approved these changes

@dajohi dajohi dajohi approved these changes

Assignees
No one assigned
Labels
test coverage Discussion and pull requests for improving test coverage.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davecgh @dajohi @jholdstock