main: improve test flag handling #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A TestMain func is added to parse the test executable's flags. Before running all tests, any flags that it did not parse (in particular, those following a double hyphen (--) which the flag package will stop parsing after) are retained in the modified os.Args value. This allows the tests that exercise go-flags options to test these options with any user-provided flags prepended. One such use case for this fix is to change the default appdata directory that tests will use, which allows tests to succeed when the default home directory is read only. For example: go test . -args -- --appdata=/some/other/appdata This well cause the go-flags tests to perform their tests with their own options being tested following the appdata change.
davecgh
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TestMain func is added to parse the test executable's flags. Before running all tests, any flags that it did not parse (in particular, those following a double hyphen (--) which the flag package will stop parsing after) are retained in the modified os.Args value. This allows the tests that exercise go-flags options to test these options with any user-provided flags prepended.
One such use case for this fix is to change the default appdata directory that tests will use, which allows tests to succeed when the default home directory is read only. For example:
go test . -args -- --appdata=/some/other/appdata
This well cause the go-flags tests to perform their tests with their own options being tested following the appdata change.
Fixes #3150.