database: Minor test cleanup. #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
test coverage
dajohi
approved these changes
Jun 14, 2023
davecgh
force-pushed
the
database_test_cleanup
branch
from
0c54fb8 to
3397354
Compare
This marks several of the funcs that are used as helpers as test helpers so any failures will be attributed to the caller as opposed to the methods themselves.
This modifies several of the tests to use t.TempDir. The directory it creates is automatically removed when the test and all its subtests complete. It also changes out some of the cleanup logic for closing the database to use t.Cleanup instead of defer to ensure the close happens during test cleanup after the directories created by t.TempDir have been removed.
davecgh
force-pushed
the
database_test_cleanup
branch
from
3397354 to
05e66dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies several of the tests in the
databasemodule to uset.TempDirand marks several of the funcs that are used as helpers as test helpers so any failures will be attributed to the caller as opposed to the methods themselves.The directory
t.TempDircreates is automatically removed when the test and all its subtests complete.Finally, it changes out some of the cleanup logic for closing the database to use
t.Cleanupinstead of defer to ensure the close happens during test cleanup after the directories created byt.TempDirhave been removed.