rpcserver: Use solved mock orphan block in tests. #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
test coverage
Currently, the RPC server getwork test for orphan block submission is rather brittle because it relies on the specific current implementation of the handler. This makes the test more robust by modifying it to solve the mock orphan block submission so that it reliably tests what it intends to even if the handler code changes.
davecgh
force-pushed
the
rpcserver_solve_mock_orphan_block
branch
from
dc9c60e to
fdf5ca9
Compare
jholdstock
approved these changes
Apr 25, 2023
dajohi
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the RPC server
getworktest for orphan block submission is rather brittle because it relies on the specific current implementation of the handler.This makes the test more robust by modifying it to solve the mock orphan block submission so that it reliably tests what it intends to even if the handler code changes.