rpcserver: Detect disconnect of ws clients. #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent commit that converted the websocket handler to use contexts failed to account for the request context not being closed when the connection is closed unlike the case in the HTTP path since the websocket hijacks the connection. This ensures the Run method terminates on websocket disconnection by selecting across both the context and the quit channel that is closed when disconnect is called.
matheusd
approved these changes
Nov 30, 2022
dnldd
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent commit that converted the websocket handler to use contexts in PR #3026 failed to account for the request context not being closed when the connection is closed unlike the case in the HTTP path since the websocket hijacks the connection.
This ensures the
Runmethod terminates on websocket disconnection by selecting across both the context and the quit channel that is closed when disconnect is called.