blockchain: Avoid unneeded view script deep copies. #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_avoid_unneeded_script_deep_copies
branch
2 times, most recently
from
105b136 to
7d7e39b
Compare
dajohi
approved these changes
Sep 8, 2022
This updates the code related to updating view entries to prevent a lot of unnecessary allocations by only deep copying the txout scripts when it is actually required due to the scripts not being the same.
davecgh
force-pushed
the
blockchain_avoid_unneeded_script_deep_copies
branch
from
7d7e39b to
f410aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code related to updating view entries to prevent a lot of unnecessary allocations by only deep copying the txout scripts when it is actually required due to the scripts not being the same.