multi: Remove index previous script snapshots. #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_remove_unused_prevscript_snapshots
branch
from
2db5def to
c30f553
Compare
dnldd
approved these changes
Aug 14, 2022
jrick
approved these changes
Aug 19, 2022
This removes the no longer used PrevScripts field from the index notification. This is part of an overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers since there are no longer any indexers that need access to it.
This removes the no longer used indexNeedsInputs function. This is part of the overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers.
This removes the no longer used NeedsInputser interface. This is part of the overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers.
This removes the no longer used PrevScripts field from the NTBlockConnected and NTBlockDisconnected notifications as well as the code that takes a snapshot populates the fields. This is part of the overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers.
This removes the code related to taking and housing previous script snapshots since it is no longer used. This is part of the overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers.
This removes the no longer used PrevScripts method from the ChainQueryer interface as well as the methods that implemented it from the tests and the blockchain query adapator. This is part of the overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers.
This removes the no longer used stxosToScriptSource function. This is part of the overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers.
This removes the no longer used PrevScripter interface. This is part of the overall effort to remove all of the code related to taking previous script snapshots and feeding them through to the indexers.
davecgh
force-pushed
the
blockchain_remove_unused_prevscript_snapshots
branch
from
c30f553 to
12873a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the address index has been removed, there are no longer any indexers that require access to previous scripts. Therefore, this removes all of the code related to taking previous script snapshots and feeding them through to the indexers via the notifications.
It is split into several commits to ease the review process and ensure the code continues to build and pass all tests each step of the way.
The following is an overview of the changes:
PrevScriptsfield from theindexers.IndexNtfnindex notificationindexers.indexNeedsInputsfunctionindexers.NeedsInputserinterfaceblockchain.PrevScriptsfield fromblockchain.BlockConnectedNtfnsDataandblockchain.BlockDisconnectedNtfnsDataand associated code that takes the snapshots to populate those fieldsblockchainPrevScriptsmethod from theindexers.ChainQueryerinterface and associated implementationsblockchain.stxosToScriptSourcefunctionindexers.PrevScripterinterface