Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mempool: Delete unreachable code in tests. #2987

Merged
merged 1 commit into from
Aug 11, 2022
Merged

mempool: Delete unreachable code in tests. #2987

merged 1 commit into from
Aug 11, 2022

Conversation

Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Aug 10, 2022 •
edited by davecgh
Loading

No description provided.

@davecgh davecgh changed the title delete minor unreachable code caused by t.Fatal mempool: Delete minor unreachable code. Aug 10, 2022
@davecgh davecgh added this to the 1.8.0 milestone Aug 10, 2022
@davecgh davecgh added the test coverage Discussion and pull requests for improving test coverage. label Aug 10, 2022
@davecgh davecgh changed the title mempool: Delete minor unreachable code. mempool: Delete unreachable code in tests. Aug 10, 2022
davecgh
davecgh approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Nice catch. It loos like those were switched over to t.Fatalf at some point and the continues weren't removed.

@davecgh davecgh merged commit 4666d81 into decred:master Aug 11, 2022
@Abirdcfly Abirdcfly deleted the patch-1 branch August 12, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
test coverage Discussion and pull requests for improving test coverage.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @davecgh