chaincfg: Deprecate subsidy split params. #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Apr 5, 2022
dajohi
approved these changes
Apr 6, 2022
JoeGruffins
approved these changes
Apr 7, 2022
rstaudt2
approved these changes
Apr 7, 2022
This deprecates the per-network subsidy split parameters for the following reasons. - They are the same on all networks so there really is no good reason to parameterize them as such - The subsidy calculation code can be simplified and made slightly more efficient without the unnecessary parameterization
davecgh
force-pushed
the
chaincfg_deprecate_split_params
branch
from
424af1d to
ab6d2fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the per-network subsidy split parameters for the following reasons.