secp256k1: Optimize precomp value storage. #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the logic that deals with generating, loading, and decompressing the compressed byte points to allow go generate to run correctly regardless of whether or not the generated file already exists. It accomplishes this by making use of a function to obtain the compressed byte points string instead of directly referencing the variable such that the function is nil by default and only set to the real function via the generated file.
This optimizes the storage of the pre-computed byte points used to accelerate scalar base multiplication to store the data as 32-byte big-endian integers instead of as a series of little-endian uint32s which reduces the amount of uncompressed bytes that need to stored by 128KiB. Further, since the compressed table is stored in the string table of the binary, it also reduces the size the of final binary by ~92.5KiB.
davecgh
force-pushed
the
secp256k1_optimize_precomp_storage
branch
from
167ec68 to
b495d21
Compare
dnldd
approved these changes
Feb 24, 2022
matheusd
approved these changes
Feb 28, 2022
JoeGruffins
approved these changes
Mar 1, 2022
rstaudt2
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2884.
This optimizes the storage of the pre-computed byte points used to accelerate scalar base multiplication to store the data as 32-byte big-endian integers instead of as a series of little-endian uint32s which reduces the amount of uncompressed bytes that need to stored by 128KiB.
Further, since the compressed table is stored in the string table of the binary, it also reduces the size the of final binary by ~92.5KiB.