-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexers: fix indexer wait for sync. #2871
Conversation
ab4f191
to
0349119
Compare
0e22e9c
to
1ab6cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty close. I identified a couple of minor things inline and it will also have to be rebased over a separate PR that bumps the major module version for blockchain
.
1ab6cc2
to
ae10646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good. This just needs a rebase over master and then I'll approve.
This fixes an issue with indexers wait for sync where the indexer gets synced before a sync subcsriber is created. The sync subscriber is left idling, waitingfor the next update which blocks the caller. The index subscriber has been updated to periodically update sync subcribers of all subscribed indexers to it as a result.
ae10646
to
fcee27b
Compare
This fixes an issue with indexers wait for sync where the indexer gets synced before a sync subscriber is created. The sync subscriber is left idling, waiting for the next update which blocks the caller. The index subscriber has been
updated to periodically update sync subscribers of all subscribed indexers to it as a result.