Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexers: fix indexer wait for sync. #2871

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Jan 18, 2022

This fixes an issue with indexers wait for sync where the indexer gets synced before a sync subscriber is created. The sync subscriber is left idling, waiting for the next update which blocks the caller. The index subscriber has been
updated to periodically update sync subscribers of all subscribed indexers to it as a result.

blockchain/indexers/indexsubscriber.go Outdated Show resolved Hide resolved
@dnldd dnldd force-pushed the fix_indexer_wait_for_sync branch from ab4f191 to 0349119 Compare January 18, 2022 14:26
blockchain/indexers/common.go Outdated Show resolved Hide resolved
blockchain/indexers/common.go Outdated Show resolved Hide resolved
blockchain/indexers/common.go Outdated Show resolved Hide resolved
blockchain/indexers/common.go Outdated Show resolved Hide resolved
@davecgh davecgh added this to the 1.8.0 milestone Jan 20, 2022
@dnldd dnldd force-pushed the fix_indexer_wait_for_sync branch from 0e22e9c to 1ab6cc2 Compare January 24, 2022 23:07
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty close. I identified a couple of minor things inline and it will also have to be rebased over a separate PR that bumps the major module version for blockchain.

blockchain/indexers/common.go Show resolved Hide resolved
blockchain/indexers/indexsubscriber.go Outdated Show resolved Hide resolved
blockchain/indexers/indexsubscriber.go Outdated Show resolved Hide resolved
@dnldd dnldd force-pushed the fix_indexer_wait_for_sync branch from 1ab6cc2 to ae10646 Compare March 24, 2022 23:42
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good. This just needs a rebase over master and then I'll approve.

This fixes an issue with indexers wait for sync where the indexer gets
synced before a sync subcsriber is created. The sync subscriber is left
idling, waitingfor the next update which blocks the caller. The index
subscriber has been updated to periodically update sync subcribers
of all subscribed indexers to it as a result.
@dnldd dnldd force-pushed the fix_indexer_wait_for_sync branch from ae10646 to fcee27b Compare March 28, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants