txscript: Break dcrutil dependency.#2626
Merged
davecgh merged 1 commit intodecred:masterfrom Apr 12, 2021
Merged
Conversation
davecgh
force-pushed
the
txscript_break_dcrutil_dep
branch
2 times, most recently
from
6cb749d to
7e23bb8
Compare
davecgh
force-pushed
the
txscript_break_dcrutil_dep
branch
from
7e23bb8 to
48f12b3
Compare
rstaudt2
approved these changes
Apr 3, 2021
davecgh
force-pushed
the
txscript_break_dcrutil_dep
branch
from
48f12b3 to
840150c
Compare
JoeGruffins
approved these changes
Apr 12, 2021
Now that the addresses have all been converted over to use the stdaddr package, this removes only remaining dependencies on dcrutil which are in the tests in order to avoid cyclic dependencies when updating the dcrutil code to the use the stdaddr package.
davecgh
force-pushed
the
txscript_break_dcrutil_dep
branch
from
840150c to
76f80ba
Compare
dajohi
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #2625.
Now that the addresses have all been converted over to use the
stdaddrpackage, this removes only remaining dependencies ondcrutilwhich are in the tests in order to avoid cyclic dependencies when updating thedcrutilcode to the use thestdaddrpackage.