Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcclient: Add GetBlockChainInfo #1539

Merged
merged 1 commit into from
Dec 8, 2018

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Dec 7, 2018

This adds support for the getblockchaininfo RPC to rpcclient.

The main package's required rpcclient module version is bumped from v1.0.2 to v1.1.0.

@chappjc
Copy link
Member Author

chappjc commented Dec 7, 2018

I'm not sure about the RPC server version bump, but I recall you saying that for a new command added to the rpcclient module, a minor version bump is required.

@davecgh
Copy link
Member

davecgh commented Dec 8, 2018

The rpcserver major was already bumped to 5.0.0 due to the notification order change, which happened after the addition of getblockchaininfo, so there is no need to bump it again.

@chappjc
Copy link
Member Author

chappjc commented Dec 8, 2018

Oh, right, sorry. I'll change that back.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't make any changes to the module versions over and above the very specific change required. In this case, it should only be modifying the main module's rpcclient version and nothing else. e.g. rpcclient/go.{mod,sum} should not be modified here.

@chappjc
Copy link
Member Author

chappjc commented Dec 8, 2018

go build actually made the wire v1.2.0 change to rpcclient/go.{mod,sum}. Since it insisted on that change, I manually did the go mod tidy in rpcclient. I see now that go build only makes that change when run from the rpcclient folder (rather than from the repo root via go build ./rpcclient or go build ./.... I don't completely understand why that should be, but I will change the rpcclient mod files back.

@chappjc chappjc force-pushed the rpcclient-getblockchaininfo branch from de9bc5f to 2bf2b16 Compare December 8, 2018 00:47
This adds support for the getblockchaininfo RPC to rpcclient,
adding asynchronous and blocking functions to rpcclient.Client.
The rpcclient module version is bumped to v1.1.0.
@chappjc chappjc force-pushed the rpcclient-getblockchaininfo branch from 2bf2b16 to a0816cf Compare December 8, 2018 00:50
@davecgh davecgh merged commit a0816cf into decred:master Dec 8, 2018
@chappjc chappjc deleted the rpcclient-getblockchaininfo branch December 8, 2018 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants