multi: Fast relay checked tip blocks. #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
Working as intended. Tested by adding some instrumentation and using a serial network layout:
https://gist.github.com/matheusd/c2d4e13cb2c68121680955e777c5057d
jrick
reviewed
Sep 10, 2018
| // Typically, a caller would want to use this notification to relay the | ||
| // block to the rest of the network without needing to wait for the more | ||
| // time consuming full connection to take place. | ||
| NTNewTipBlockChecked NotificationType = iota |
There was a problem hiding this comment.
why can't this be added to the end, to leave the other constants the same values?
There was a problem hiding this comment.
I prefer to have them defined in the order they are invoked.
There was a problem hiding this comment.
Nevermind, these constants should only be referred to by their name, not literals, and afaik they are not serialized anywhere.
There was a problem hiding this comment.
Correct. They are not serialized anywhere.
jrick
approved these changes
Sep 10, 2018
This adds a new function to peers which allows an inventory vector to be queued for immediate send versus the standard trickling batched inventory queue method while still respecting the functionality which filters attempts to notify peers about inventory that they are already known to have.
This modifies the infrastructure for the server inventory relay to allow the caller to specify the inventory should be announced immediately versus using the typical trickle mechanism. It also updates all callers in the repository and changes the relay of accepted blocks use the new ability.
This adds a new notification type to blockchain which allows the caller to be notified when a block that intents to extend the main chain has passed all sanity and contextual checks such as having valid proof of work, valid merkle and stake roots, and only containing allowed votes and revocations. The intention is to allow faster relay of new tip blocks throughout the network by providing a means to relay it before the more expensive connection code takes place even though it may ultimately fail to connect. This is acceptable because blocks that pass all of the aforementioned checks and then fail to connect are quite rare since it takes a significant amount of work to create a block which satisfies the proof of work requirement as well as all other checks up to that point.
This makes use of the newly exposed notification from blockchain when a block that intends to extend the main chain has passed all sanity and contextual checks to relay the block the rest of the network at that point rather than needing to wait for the more expensive connection code to complete.
davecgh
force-pushed
the
multi_immediate_block_relay
branch
from
38ba952 to
fefb892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of several commits which ultimately immediately relays blocks that intend to extend the main chain to the rest of the network directly after they have passed all sanity and contextual checks rather than waiting for the more expensive connection code to complete.
This is acceptable because blocks that pass all of the aforementioned checks and then fail to connect are quite rare since it takes a significant amount of work to create a block which satisfies the proof of work requirement as well as all other checks up to that point.
The first commit adds a new function to
peernamedQueueInventoryImmediatewhich allows an inventory vector to be queued for immediate send versus the standard trickling batched inventory queue method while still respecting the functionality which filters attempts to notify peers about inventory that they are already known to have.The second commit modifies the infrastructure for
serverinventory relay to allow the caller to specify the inventory should be announced immediately versus using the typical trickle mechanism, updates all callers in the repository accordingly, and changes the relay of accepted blocks use the new ability.The third commit adds a new notification type to
blockchainnamedNTNewTipBlockCheckedwhich allows the caller to be notified when a block that intents to extend the main chain has passed all sanity and contextual checks such as having valid proof of work, valid merkle and stake roots, and only containing allowed votes and revocations.Finally, the fourth commit makes use of the newly exposed notification from
blockchainto relay the block the rest of the network at that point rather as previously described.