blockchain: Correct best pool size on disconnect. #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Aug 31, 2018
davecgh
force-pushed
the
blockchain_correct_disconnect_beststate_poolsize
branch
from
f097d21 to
c55be06
Compare
alexlyp
approved these changes
Aug 31, 2018
This corrects the NextPoolSize field that was recently added to the best state when a block is disconnected to calculate the next pool size relative to the previous block since it will become the new best state.
davecgh
force-pushed
the
blockchain_correct_disconnect_beststate_poolsize
branch
from
c55be06 to
2a18beb
Compare
JFixby
pushed a commit
to JFixby/dcrd
that referenced
this pull request
Sep 20, 2019
txscript: handle variable length P2PKH signatures in ComputePkScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the
NextPoolSizefield that was recently added to the best state when a block is disconnected to calculate the next pool size relative to the previous block since it will become the new best state.