multi: move MinHighPriority into mining package. #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
mv_minhighpriority
branch
from
f2e6609 to
52efbde
Compare
davecgh
changed the title
davecgh
requested changes
Aug 24, 2018
jrick
reviewed
Aug 24, 2018
dnldd
force-pushed
the
mv_minhighpriority
branch
from
52efbde to
1fc2502
Compare
davecgh
requested changes
Aug 25, 2018
mempool/mempool.go
Outdated
| @@ -34,8 +34,10 @@ const ( | |||
|
|
|||
| // MinHighPriority is the minimum priority value that allows a | |||
| // transaction to be considered high priority. | |||
| // | |||
| // Deprecated: Use mining.MinHighPriority | |||
| // TODO: Remove in next version update. | |||
| MinHighPriority = dcrutil.AtomsPerCoin * 144.0 / 250 | |||
There was a problem hiding this comment.
Rather than leaving the second definition, which can easily get out of date, please define this in terms of the new one. That is to say:
// MinHighPriority is the minimum priority value that allows a
// transaction to be considered high priority.
//
// Deprecated: Use mining.MinHighPriority
// TODO: Remove in next version update.
MinHighPriority = mining.MinHighPriority
dnldd
force-pushed
the
mv_minhighpriority
branch
from
1fc2502 to
f5f97ed
Compare
dnldd
force-pushed
the
mv_minhighpriority
branch
from
f5f97ed to
1110580
Compare
dnldd
force-pushed
the
mv_minhighpriority
branch
from
1110580 to
94b3ccd
Compare
dnldd
force-pushed
the
mv_minhighpriority
branch
from
94b3ccd to
3b33c0c
Compare
This was referenced Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #1417, #1418, #1419 and #1420.
Port of upstream commit a18f883.