mempool: Make expiry pruning self contained. #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Jul 25, 2018
davecgh
force-pushed
the
mempool_self_contained_expiry_pruning
branch
from
bcf1cea to
6fbd4ff
Compare
This modifies the mempool to handle pruning of expired transactions in a self-contained way so that the caller is not responsible for worrying about the specific semantics of height and expiration interplay and updates all callers in the repository accordingly. It also adds a test which ensures the behavior is correct by creating a series of transactions with expirations, adding them just before the point at which they will expire, and then advancing the chain so that each transaction expires and thus should be pruned.
davecgh
force-pushed
the
mempool_self_contained_expiry_pruning
branch
from
6fbd4ff to
a983886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
mempoolto handle pruning of expired transactions in a self-contained way so that the caller is not responsible for worrying about the specific semantics of height and expiration interplay and updates all callers in the repository accordingly.It also adds a test which ensures the behavior is correct by creating a series of transactions with expirations, adding them just before the point at which they will expire, and then advancing the chain so that each transaction expires and thus should be pruned.