txscript: Remove DER signature verification flag. #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Jul 2, 2018
This removes the ScriptVerifyDERSignatures flag from the txscript package, changes the default semantics to always enforce its behavior and updates all callers in the repository accordingly. This change is being made to simplify the script engine code since the flag has always been active and required by consensus in Decred, so there is no need to require a flag to conditionally toggle it. It should be noted that the tests removed from script_tests.json specifically dealt with ensuring non-DER-compliant signatures were handled properly when the ScriptVerifyDERSignatures flag was not set. Therefore, they are no longer necessary. Finally, the DERSIG indicator to enable the flag in the test data has been retained for now in order to keep the logic changes separate.
davecgh
force-pushed
the
txscript_remove_dersig_flag
branch
from
22aa10a to
98e0b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on PR #1322.
This removes the
ScriptVerifyDERSignaturesflag from thetxscriptpackage, changes the default semantics to always enforce its behavior and updates all callers in the repository accordingly.This change is being made to simplify the script engine code since the flag has always been active and required by consensus in Decred, so there is no need to require a flag to conditionally toggle it.
It should be noted that the tests removed from
script_tests.jsonspecifically dealt with ensuring non-DER-compliant signatures were handled properly when theScriptVerifyDERSignaturesflag was not set. Therefore, they are no longer necessary.Finally, the
DERSIGindicator to enable the flag in the test data has been retained for now in order to keep the logic changes separate.