dcrjson: add fundrawtransaction command #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
requested changes
Jul 2, 2018
vctt94
force-pushed
the
addFundrawtransaction
branch
2 times, most recently
from
aed10ff to
20506e1
Compare
vctt94
force-pushed
the
addFundrawtransaction
branch
from
20506e1 to
1bdf1cc
Compare
|
I changed to use just one parameter, now I believe this PR is ready for another review. |
jrick
requested changes
Jul 19, 2018
| @@ -240,6 +240,33 @@ func NewEstimatePriorityCmd(numBlocks int64) *EstimatePriorityCmd { | |||
| } | |||
| } | |||
|
|
|||
| // FundRawTransactionOptions represents the optional inputs to fund | |||
| // a raw transaction. | |||
| type FundRawTransactionOptions struct { | |||
There was a problem hiding this comment.
This type must use json:"..." struct tags to provide the key name
dcrjson/walletsvrcmds.go
Outdated
| // FundRawTransactionOptions represents the optional inputs to fund | ||
| // a raw transaction. | ||
| type FundRawTransactionOptions struct { | ||
| ChangeAccount *string |
There was a problem hiding this comment.
The change account is not part of the equivalent bitcoind RPC (instead, any address can be provided as an option). Why is this different?
dcrjson/walletsvrcmds.go
Outdated
| // a raw transaction. | ||
| type FundRawTransactionOptions struct { | ||
| ChangeAccount *string | ||
| LockUnspents *bool `jsonrpcdefault:"false"` |
There was a problem hiding this comment.
Let's not add this for now. Locking outputs doesn't actually work in dcrwallet currently.
dcrjson/walletsvrcmds.go
Outdated
| ChangeAccount *string | ||
| LockUnspents *bool `jsonrpcdefault:"false"` | ||
| FeeRate *float64 | ||
| RequiredConfirmations *int32 |
|
fixed |
jrick
approved these changes
Jul 28, 2018
davecgh
approved these changes
Jul 29, 2018
JFixby
pushed a commit
to JFixby/dcrd
that referenced
this pull request
Oct 21, 2018
connmanager: check Addr for nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to decred/dcrwallet#1195