rpcclient: Implement fmt.Stringer for Client #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Jun 14, 2018
jrick
force-pushed
the
clientstring
branch
2 times, most recently
from
105c76a to
2ece4f0
Compare
davecgh
reviewed
Jun 14, 2018
This implements fmt.Stringer by returning the URL of the RPC server that the client makes requests to. Since the client config is not exported by Client, this is now the only way to return the scheme, host, and endpoint the server.
|
Updated |
davecgh
approved these changes
Jun 14, 2018
|
Let's move discussion to that issue. I have a few thoughts about the design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements fmt.Stringer by returning the URL of the RPC server
that the client makes requests to.
Since the client config is not exported by Client, this is now the
only way to return the scheme, host, and endpoint the server.