addrmgr: Fix race in save peers. #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Jun 4, 2018
This modifies the savePeers function in the addrmgr package to lock the mutex before checking if saving is needed because the flag is accessed from multiple goroutines.
davecgh
force-pushed
the
addrmgr_save_peers_mutex
branch
from
0cb663e to
b730f98
Compare
JFixby
pushed a commit
to JFixby/dcrd
that referenced
this pull request
Oct 21, 2018
btcjson: use int64 for GetBlockHeader[Verbose] confirmations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
savePeersfunction in theaddrmgrpackage to lock the mutex before checking if saving is needed because the flag is accessed from multiple goroutines.