peer: Negotiate protocol ver before sending reject. #1249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rearranges some of the function definitions that pertain to initial peer version negotiation and bringup so they are more consistent with the preferred order used throughout the codebase. In particular, the functions are defined before they're first used and generally as close as possible to the first use when they're defined in the same file. There are no functional changes.
This removes an impossible to hit duplicate version check and adds a test to ensure the behavior is correct. Previously, the check was necessary because the handler was a part of the input handler loop, however, the initial negotiation logic was refactored some time ago to be synchronous and thus it is no longer possible to receive a second version message in the refactored code path.
This modifies the initial peer protocol negotiation logic to negotiate the protocol version before sending any reject messages.
davecgh
force-pushed
the
peer_negotiate_pver_before_send
branch
from
e10242b to
3711159
Compare
|
Closing in favor of #1250 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of PR #1248.
This modifies the initial peer protocol negotiation logic to negotiate the protocol version before sending any reject messages.