mempool: use secp256k1 functions directly. #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
May 18, 2018
mempool/policy_test.go
Outdated
| pubKeys = append(pubKeys, chainec.Secp256k1.NewPublicKey(pk.Public()).SerializeCompressed()) | ||
| pk := secp256k1.NewPrivateKey(big.NewInt(int64(chainec.ECTypeSecp256k1))) | ||
| pubKeys = append(pubKeys, | ||
| secp256k1.NewPublicKey(pk.Public()).SerializeCompressed()) |
There was a problem hiding this comment.
Recall from the previous PR that there is no need to decompose it into X and Y and create a new public key from it. Plus, .Public() is going to be removed. Just cast it.
mempool/policy_test.go
Outdated
| @@ -101,8 +102,9 @@ func TestCalcMinRequiredTxRelayFee(t *testing.T) { | |||
| func TestCheckPkScriptStandard(t *testing.T) { | |||
| var pubKeys [][]byte | |||
| for i := 0; i < 4; i++ { | |||
| pk := chainec.Secp256k1.NewPrivateKey(big.NewInt(int64(chainec.ECTypeSecp256k1))) | |||
| pubKeys = append(pubKeys, chainec.Secp256k1.NewPublicKey(pk.Public()).SerializeCompressed()) | |||
| pk := secp256k1.NewPrivateKey(big.NewInt(int64(chainec.ECTypeSecp256k1))) | |||
There was a problem hiding this comment.
I don't see any reason to retain the reference to chainec here. It's just generating a new private key from a fixed value for testing purposes. You can replace it with big.NewInt(0).
This PR replaces chainec function calls within the mempool packagewith the underlining secp256k1 functions. This is in preparation forremoving the chainec package.
dnldd
force-pushed
the
remove_mempool_chainecrefs
branch
from
1375025 to
3c94b98
Compare
davecgh
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces chainec function calls within the mempool package
with the underlining secp256k1 functions. This is in preparation for
removing the chainec package.
This is work towards #1191