dcrjson: add estimatesmartfee #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
May 11, 2018
dcrjson/chainsvrcmds.go
Outdated
| // estimatefee JSON-RPC command. | ||
| func NewEstimateFeeCmd(numBlocks int64) *EstimateFeeCmd { | ||
| return &EstimateFeeCmd{ | ||
| NumBlocks: numBlocks, | ||
| } | ||
| } | ||
|
|
||
| // EstimateSmartFeeMode defines estimation mode to be used with | ||
| // the estimatesmartfee command. | ||
| type EstimateSmartFeeMode int |
There was a problem hiding this comment.
I think this should be a string as numbers change over time and adding new string modes is much less likely to break older clients.
dcrjson/chainsvrresults.go
Outdated
| type EstimateSmartFeeResult struct { | ||
| FeeRate float64 `json:"feerate"` | ||
| Error []string `json:"error"` | ||
| blocks int64 `json:"blocks"` |
dcrjson/chainsvrcmds.go
Outdated
| const ( | ||
| // EstimateSmartFeeEconomical returns an | ||
| // economical result. | ||
| EstimateSmartFeeEconomical EstimateSmartFeeMode = iota |
There was a problem hiding this comment.
As mentioned this would be better as a string, so with that change, this comment will become moot, but values used in RPC APIs generally shouldn't use iota because they need to be stable, unlike internal APIs where it doesn't really matter if the actual numbers change.
dnldd
approved these changes
May 13, 2018
davecgh
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.