Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcserver: fix jsonRPCRead data race. #1157

Merged
merged 1 commit into from
Mar 24, 2018
Merged

rpcserver: fix jsonRPCRead data race. #1157

merged 1 commit into from
Mar 24, 2018

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Mar 23, 2018

resolves #1142

jrick
jrick approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me

@dajohi please test this with the miner node

@jrick jrick requested a review from dajohi March 23, 2018 01:49
@davecgh
Copy link
Member

davecgh commented Mar 23, 2018

I'll wait for confirmation on whether or not it actually resolves #1142, but this is correct regardless.

dajohi
dajohi approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@dajohi dajohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davecgh davecgh merged commit 0fc5525 into decred:master Mar 24, 2018
@dnldd dnldd deleted the jsonrpcreadrace branch June 4, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajohi dajohi dajohi approved these changes

@davecgh davecgh davecgh approved these changes

@jrick jrick jrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data race
4 participants
@dnldd @davecgh @jrick @dajohi