dcrjson: Add SweepAccountCmd & SweepAccountResult. #1027
Conversation
dcrjson/dcrwalletextcmds.go
Outdated
|
|
||
| // SweepAccountCmd defines the sweep account JSON-RPC command. | ||
| type SweepAccountCmd struct { | ||
| SourceAccount uint32 |
There was a problem hiding this comment.
the json-rpc api uses account names (strings) to refer to accounts
dcrjson/dcrwalletextcmds.go
Outdated
| type OutputDestination struct { | ||
| Address string | ||
| Script []byte | ||
| ScriptVersion uint32 |
There was a problem hiding this comment.
we probably don't need the script and script version, and can just work with an address string instead of this type. P2SH is a better idea anyways for using custom scripts
dcrjson/dcrwalletextcmds.go
Outdated
| type SweepAccountCmd struct { | ||
| SourceAccount uint32 | ||
| RequiredConfirmations uint32 | ||
| FeePerKb dcrutil.Amount |
There was a problem hiding this comment.
since json-rpc request parameters are positional, and we want the required confirmations and fee to be configurable but use the wallet defaults, these two must come last.
Additionally, the json-rpc api uses json numbers between 0-21M when referring to amounts, so this must be a float64 (we should not be importing dcrutil at all here)
dcrjson/dcrwalletextcmds.go
Outdated
| SourceAccount uint32 | ||
| RequiredConfirmations uint32 | ||
| FeePerKb dcrutil.Amount | ||
| ChangeDestination *OutputDestination |
There was a problem hiding this comment.
Is ChangeDestination where the account is swept to? I'm assuming so, but this needs a different name. Perhaps just DestinationAddress string (see comments above about not needing the scripts).
dcrjson/dcrwalletextcmds.go
Outdated
| } | ||
|
|
||
| // NewSweepAccountCmd returns a new instance which can be used to issue a JSON-RPC SweepAccountCmd command. | ||
| func NewSweepAccountCmd(sourceAccount uint32, requiredConfs uint32, feePerKb *dcrutil.Amount, changeDestination *OutputDestination) *SweepAccountCmd { |
There was a problem hiding this comment.
after reordering the request parameters in the struct, these should be reordered as well.
dcrjson/dcrwalletextresults.go
Outdated
| @@ -5,6 +5,8 @@ | |||
|
|
|||
| package dcrjson | |||
|
|
|||
| import "github.com/decred/dcrd/dcrutil" | |||
There was a problem hiding this comment.
no dcrutil import, use float64 for amounts
dcrjson/dcrwalletextresults.go
Outdated
| // SweepAccountResult models the data returned from the sweepaccount | ||
| // command. | ||
| type SweepAccountResult struct { | ||
| UnsignedTransaction []byte `json:"unsignedTransaction"` |
There was a problem hiding this comment.
binary data must be a hexadecimal string in the json-rpc api
There was a problem hiding this comment.
Additionally, the json struct tags must use all lowercase for consistency with the rest of the api.
dnldd
force-pushed
the
sweepaccount
branch
3 times, most recently
from
29fbc2b to
6a461c8
Compare
No description provided.