mempool: Rename RelayNonStd config option. #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames the mempool.Config.RelayNonStd option to AcceptNonStd which more accurately describes its behavior since the mempool was refactored into a separate package. The reasoning for this change is that the mempool is not responsible for relaying transactions (nor should it be). Its job is to maintain a pool of unmined transactions that are validated according to consensus and policy configuration options which are then used to provide a source of transactions that need to be mined. Instead, it is the server that is responsible for relaying transactions. While it is true that the current server code currently only relays txns that were accepted to the mempool, this does not necessarily have to be the case. It would be entirely possible (and perhaps even a good idea as something do in the future), to separate the relay policy from the mempool acceptance policy (and thus indirectly the mining policy).
|
I'm not sure I completely agree with the renaming here. It no longer conveys that those transactions will be relayed to the rest of the network, which is important. That said, if the comments and descriptions are updated accordingly, I think it's acceptable. |
This renames the mempool.Config.RelayNonStd option to AcceptNonStd which more accurately describes its behavior since the mempool was refactored into a separate package. The reasoning for this change is that the mempool is not responsible for relaying transactions (nor should it be). Its job is to maintain a pool of unmined transactions that are validated according to consensus and policy configuration options which are then used to provide a source of transactions that need to be mined. Instead, it is the server that is responsible for relaying transactions. While it is true that the current server code currently only relays txns that were accepted to the mempool, this does not necessarily have to be the case. It would be entirely possible (and perhaps even a good idea as something do in the future), to separate the relay policy from the mempool acceptance policy (and thus indirectly the mining policy).
dnldd
force-pushed
the
merge_mempool_rename_relaynonstd
branch
from
47d57bb to
e48b9ab
Compare
davecgh
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following upstream commits:
RelayNonStdTxstoAcceptNonStdTxsfor network params, renamingRelayNonStdtoAcceptNonStdfor dcrd's config struct and renamingrelaynonstdconfig param toacceptnonstd. The sample config and doc entries were also updated accordingly.