handle weather forecast callback delay #586 #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decompil3d
requested changes
Jan 22, 2024
handle if HA not supports subscription
|
Please check, I am ready with the requested changes. |
decompil3d
requested changes
Jan 29, 2024
| @@ -329,6 +331,7 @@ export class HourlyWeatherCard extends LitElement { | |||
| } | |||
|
|
|||
| if (!forecastNotAvailable && numSegments > (forecast.length - offset)) { | |||
| if (pending) return; | |||
There was a problem hiding this comment.
I'm worried about hiding this error in cases where the user has actually tried to configure the card to show more segments than the entity has available. I'm wondering if we should just make forecastNotAvailable be true if the forecast is pending.
There was a problem hiding this comment.
I think this is covered. Am I missing something?
When loading from the attribute (and subscription is available, yet not loaded) the error will be pending and will not be displayed.
Later on when the subscription returns and still number of segments are less than configured pending will be false, thus error is shown.
decompil3d
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added pending temporary state - until the callback is not returned - to skip rendering any error messages in this state #586.
Please comment / modify if you see any better approach to circumvent the problem (e.g. delayed rendering).