Feature: Option to round fractional temperatures to whole numbers #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattchesters
changed the title
decompil3d
requested changes
Dec 23, 2023
Co-authored-by: Jonathan Keslin <[email protected]>
decompil3d
requested changes
Dec 27, 2023
Co-authored-by: Jonathan Keslin <[email protected]>
|
Would there be a chance to merge this PR? It is an awesome addition. |
decompil3d
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional option to display fractional hourly temperatures into their nearest whole number.
Behavior change:
By default, the existing default behavior is observed, where fractional temperatures are rendered if the weather entity is serving fractional temperatures.
When the
round_temperatures: trueis specified, the number served by weather entity is rounded to the nearest whole number using Math.round().Tests
Tests have been modified, to include a fractional temperature in mock data.