Conversation
Contributor
Author
|
Bảo trì: đã merge upstream eb712ca và push thường tip 8400a34. Diff còn 4 file, giữ local-only guards và PXPIPE opt-out. Review độc lập không thấy blocker; 39/39 scoped tests pass. Cohort liên quan có 1 lỗi headroom-detect Windows path, đã tái hiện trên upstream cùng SHA; không sửa lỗi ngoài phạm vi trong PR này. git diff --check pass. Chưa chạy full suite hoặc live provider. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-9Router-Token-Saver: offdisable PXPIPE as well as RTK, Headroom, Caveman, and PonytailSecurity context
When dashboard login is disabled, generic
/api/*routes are intentionally available remotely. Child-process/package-manager routes remain local-only. This PR extends that existing boundary to:/api/pxpipe/*/api/headroom/extras/api/headroom/restartPXPIPE installs a hardcoded
pxpipe-proxy@latestpackage; this is a package-manager execution boundary, not attacker-controlled package selection. Headroom extras are also constrained to a closedcode/mlwhitelist.This PR supersedes #3078 by including its
/api/pxpipeguard plus Headroom coverage and focused tests. It does not close #3078 automatically.Behavior
403, even whenrequireLogin=falseX-9Router-Token-Saver: offorOFFreturns PXPIPE skip telemetry (applied:false,reason:"disabled") and leaves the request body unchangedTest plan
unit/dashboard-guard.test.jsunit/headroom-chat-core.test.jsunit/pxpipe.test.jsScope
Exactly four files. No dependency, version, changelog, Headroom pipeline, or system-injection changes.