Conversation
bloodf
pushed a commit
to bloodf/durindoor
that referenced
this pull request
Jul 10, 2026
…tructions Ported from decolua/9router#2508 @ 6b2eaf0b40fbe5e4e246e2092c07fa2a0a719764. Routes Codex/OpenAI-Responses token-saver system prompts to the top-level `instructions` field instead of injecting a synthetic system entry into input[], which Codex rejects.
bloodf
pushed a commit
to bloodf/durindoor
that referenced
this pull request
Jul 10, 2026
…tructions Ported from decolua/9router#2508 @ 6b2eaf0b40fbe5e4e246e2092c07fa2a0a719764. Routes Codex/OpenAI-Responses token-saver system prompts to the top-level `instructions` field instead of injecting a synthetic system entry into input[], which Codex rejects.
bloodf
pushed a commit
to bloodf/durindoor
that referenced
this pull request
Jul 10, 2026
…tructions Ported from decolua/9router#2508 @ 6b2eaf0b40fbe5e4e246e2092c07fa2a0a719764. Routes Codex/OpenAI-Responses token-saver system prompts to the top-level `instructions` field instead of injecting a synthetic system entry into input[], which Codex rejects.
bloodf
pushed a commit
to bloodf/durindoor
that referenced
this pull request
Jul 10, 2026
…tructions Ported from decolua/9router#2508 @ 6b2eaf0b40fbe5e4e246e2092c07fa2a0a719764. Routes Codex/OpenAI-Responses token-saver system prompts to the top-level `instructions` field instead of injecting a synthetic system entry into input[], which Codex rejects.
bloodf
pushed a commit
to bloodf/durindoor
that referenced
this pull request
Jul 10, 2026
…tructions Ported from decolua/9router#2508 @ 6b2eaf0b40fbe5e4e246e2092c07fa2a0a719764. Routes Codex/OpenAI-Responses token-saver system prompts to the top-level `instructions` field instead of injecting a synthetic system entry into input[], which Codex rejects.
bloodf
added a commit
to bloodf/durindoor
that referenced
this pull request
Jul 10, 2026
…tructions (#162) Ported from decolua/9router#2508 @ 6b2eaf0b40fbe5e4e246e2092c07fa2a0a719764. Routes Codex/OpenAI-Responses token-saver system prompts to the top-level `instructions` field instead of injecting a synthetic system entry into input[], which Codex rejects. Co-authored-by: port-bot <port@local>
|
this thing gotta be merged asap |
hohaivu
added a commit
to hohaivu/9router
that referenced
this pull request
Jul 15, 2026
Token Saver/Caveman injected a chat-style {role:"system"} message into
input[] for Responses-style requests with no existing instructions
field. Codex GPT-5.6 rejects that shape ("Unknown parameter:
'input[0].content'"). Append to top-level instructions instead for
openai-responses/openai-response/codex formats; unchanged for
chat-completions.
Closes upstream decolua#2497. Cherry-picked from upstream PR decolua#2508.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
maintainers, merge this please |
afandiaziz
pushed a commit
to afandiaziz/9router
that referenced
this pull request
Aug 9, 2026
29 PR upstream di-cherry-pick (semua masih open upstream per 2026-08-09). Rincian lengkap + link per PR ada di FORK-CHANGES.md. P1 skala 2475 koneksi : decolua#2798 decolua#410 decolua#2879 decolua#879 decolua#2997 P2 akurasi token/usage: decolua#2422 decolua#2658 decolua#2762 decolua#2453 decolua#2668 decolua#2361 P3 provider & combo : decolua#2526 decolua#3125 decolua#1434 decolua#2689 decolua#2439 decolua#2724 decolua#2647 decolua#1805 decolua#2909 decolua#2853 decolua#2508 decolua#2928 decolua#2345 decolua#2112 decolua#2786 P4 keamanan : decolua#1666 decolua#2776 Revert decolua#664: menambah transformRequest kedua di DefaultExecutor sehingga menimpa yang pertama dan mematikan stream_options/text.format/ injectReasoningContent/stripUnsupportedParams — termasuk PR decolua#3081 yang sudah dipakai produksi. Test: 88 gagal / 1783 lulus — nol regresi vs baseline v0.5.50 (88/1656).
hohaivu
added a commit
to hohaivu/9router
that referenced
this pull request
Aug 14, 2026
Token Saver/Caveman injected a chat-style {role:"system"} message into
input[] for Responses-style requests with no existing instructions
field. Codex GPT-5.6 rejects that shape ("Unknown parameter:
'input[0].content'"). Append to top-level instructions instead for
openai-responses/openai-response/codex formats; unchanged for
chat-completions.
Closes upstream decolua#2497. Cherry-picked from upstream PR decolua#2508.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Token Saver/Caveman prompt injection for Codex/OpenAI Responses requests.
When Token Saver injected a system prompt into a Responses-style request with no existing
instructionsfield, it fell back to inserting a chat-style message intoinput[]:Codex GPT-5.6 rejects that shape because Responses
input[]entries must use Responses item/content schemas, so requests failed with:Changes
injectMessagesSystem.openai-responses,openai-response, andcodexformats, append Token Saver/Caveman prompt text to top-levelinstructionsinstead of mutatinginput[].systemmessage inmessages[].instructionsfield.instructions.messages[]injection behavior.Verification
Result:
Closes #2497