Conversation
bloodf
pushed a commit
to bloodf/9router
that referenced
this pull request
Jun 19, 2026
3 of 4 tasks
diegosouzapw
pushed a commit
to diegosouzapw/OmniRoute
that referenced
this pull request
Jun 26, 2026
…clients OpenAI Responses-API clients send the reasoning hint as `reasoning.effort`. On the Chat-Completions side it is `reasoning_effort` (OpenAI-native). The existing translator only promoted it behind the `_copilotClient` UA gate so every other Responses client (OpenCode, Cursor, raw OpenAI Responses, ...) silently lost the hint when routed across formats. Promote `reasoning.effort` -> `reasoning_effort` unconditionally; keep the Copilot-specific `summary` -> Claude summarized-thinking marker behind the existing UA gate because that one IS Copilot-specific glue, not an OpenAI-native field. Existing test that pinned the old (gated) contract is updated with a comment pointing at the upstream PR. Co-authored-by: ryanngit <74137224+ryanngit@users.noreply.github.com> Inspired-by: decolua/9router#1817
ryanngit
force-pushed
the
reasoning-effort-translation
branch
from
July 3, 2026 20:11
d1407c1 to
a3d5ea0
Compare
ryanngit
changed the title
Contributor
Author
|
Superseded by #2452, which keeps the same fix set in one branch and has focused tests passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks