Conversation
Delcado19
force-pushed
the
fix/sidebar-visible-1481
branch
from
June 8, 2026 05:21
1a99d52 to
6952d06
Compare
diegosouzapw
pushed a commit
to diegosouzapw/OmniRoute
that referenced
this pull request
Jun 26, 2026
Replace the fragile `hidden`/`lg:flex` Tailwind cascade on the desktop sidebar wrapper with an explicit `.dashboard-sidebar-desktop` class backed by a 1024px media query in globals.css. Class ordering/specificity could collapse the `lg:flex` override and leave the desktop dashboard sidebar permanently hidden; the dedicated class is order-independent. The class keeps `min-height: 0` to preserve the previous `min-h-0` behavior. Co-authored-by: Delcado <85063283+Delcado19@users.noreply.github.com> Inspired-by: decolua/9router#1504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hidden lg:flexdependency with a scoped CSS classFixes #1481.
Validation
dashboard-sidebar-desktop