Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

studio(a11y): main menu has not enough contrast #554

Closed
1 of 8 tasks
donroyco opened this issue Dec 24, 2019 · 6 comments
Closed
1 of 8 tasks

studio(a11y): main menu has not enough contrast #554

donroyco opened this issue Dec 24, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request studio "Studio" is the codename for the web editor

Comments

@donroyco
Copy link
Contributor

Affected part of DeckDeckGo

  • Studio
  • Remote control
  • Documentation
  • Demo
  • Starter kit
  • Poll
  • Web Components
  • Templates

Reproduction

Steps to reproduce:

  1. Go to https://deckdeckgo.com/
  2. Click the main menu

Expected Behavior

The contrast between font color and background color should be high enough.

Actual Behavior

DeckDeckGo main menu

When checking above colors on their contrast ratio, it fails.

Who Can Use contrast

The provided contrast fails for basically everyone, according to Who Can Use. It may be hard to solve this problem, since #3880ff is part of DeckDeckGo's identity.

Environment

  • Browser(s): Chrome, latest version
  • Operating System (e.g. Windows, macOS, Ubuntu): macOS
@peterpeterparker
Copy link
Contributor

Fully agree, probably the same with the dark mode menu aka both light and dark mode!

Thx for pinging us about this 👍

@peterpeterparker peterpeterparker added enhancement New feature or request studio "Studio" is the codename for the web editor labels Dec 24, 2019
@donroyco
Copy link
Contributor Author

@peterpeterparker Anytime. While playing with WCU, I saw that changing the font-size to 19px and making it bold, the WCAG grading goes to AA. Not sure if that makes it prettier, it makes it a least more useful.

@peterpeterparker peterpeterparker self-assigned this Jan 10, 2020
@peterpeterparker peterpeterparker added this to the studio-beta.11 milestone Jan 10, 2020
peterpeterparker added a commit that referenced this issue Jan 10, 2020
Signed-off-by: peterpeterparker <[email protected]>
peterpeterparker added a commit that referenced this issue Jan 10, 2020
@peterpeterparker
Copy link
Contributor

@donroyco contrast will be better I hope with the PR I just merged:

light mode:

Capture d’écran 2020-01-10 à 10 01 00

dark mode:

Capture d’écran 2020-01-10 à 10 00 55

@peterpeterparker
Copy link
Contributor

Thx for the issue 👍

@donroyco
Copy link
Contributor Author

Thanks for the improvement @peterpeterparker !

@peterpeterparker
Copy link
Contributor

😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request studio "Studio" is the codename for the web editor
Projects
None yet
Development

No branches or pull requests

2 participants