Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

studio: theme and palette for color picker #350

Open
peterpeterparker opened this issue Sep 21, 2019 · 4 comments
Open

studio: theme and palette for color picker #350

peterpeterparker opened this issue Sep 21, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers studio "Studio" is the codename for the web editor

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Sep 21, 2019

Description

A custom color picker has been implemented (#260)

The next steps is to define palette of colors and to provide them to the picker. Maybe a dropdown of palette which change the pickers

Or even a step further, being able to select a palette for the all presentation and if the palette change, then all the presentations colors change (that' would be a bit crazy to develop)?

Development

Important: if we add multiple palette, we should pay attention to the performance. important than these are only fetched when needed.

@peterpeterparker peterpeterparker added enhancement New feature or request studio "Studio" is the codename for the web editor labels Sep 21, 2019
@peterpeterparker peterpeterparker added the good first issue Good for newcomers label Sep 28, 2019
@bzuillsmith
Copy link

bzuillsmith commented Sep 29, 2019

This is a basic example of what I would hope we could eventually do. Just a rough sketch so-to-speak with some notes about functionality for deck deck go. I hope to iteratively work on this over this week and complete the todo list. https://codepen.io/bzuillsmith/pen/MWgdOVm

@peterpeterparker
Copy link
Contributor Author

@bzuillsmith really fancy 👍

not sure exactly how to fit in the current editor design though? currently, the options are displayed either in a right pane/popover or in the WYSIWG editor

maybe a design we could use in the new ux of the remote (#228) to pick a color to draw over a presentation?

@bzuillsmith
Copy link

I'm thinking this could be used on paint bucket in the wysiwyg. You could preview the color on hover and you won't have the darker overlay that comes from the popover so you see the real color as you choose one. One challenge is limited space for the palette and no opacity... I suppose the popover would still be needed for colors like that.

@peterpeterparker
Copy link
Contributor Author

peterpeterparker commented Sep 29, 2019

The darker overlay could actually be turned off (Ionic offers such an option out of the box). I had a try but I found the result a bit weird, kind of missed the difference between the popover and the content.

Yep agree all options are currently displayed in the popover. I think it's better to stick to one UX for all actions therefore right now, use the popover.

On the other hand, the wysiwyg editor ("on text selection") is not displayed in a popover but in a popup, so yep maybe it would fit there. I've added the "rough" color picker in the popup too, maybe not as shiny but it seems to be, let say, kind of acceptable, what do you think?

"on hover" would be nice but unfortunately, I think about it now, we've got a limitation there. There isn't any "on hover" on mobile devices :(

I found your example super fancy but I'm still not sure how we could integrate it in the current UX and limitations of the editor.

On the other side, in the remote when the user select "drawing over the presentation", we should think about it. Right now use could only pick red or black, more options would be cool.

@peterpeterparker peterpeterparker added the hacktoberfest-accepted Good for Hacktoberfest label Oct 3, 2019
@peterpeterparker peterpeterparker removed the hacktoberfest-accepted Good for Hacktoberfest label Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers studio "Studio" is the codename for the web editor
Projects
None yet
Development

No branches or pull requests

2 participants