This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 184
Obfuscate reveal action #224
Labels
Milestone
Comments
peterpeterparker
added
enhancement
New feature or request
good first issue
Good for newcomers
core
Core
studio
"Studio" is the codename for the web editor
labels
Aug 9, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 10, 2019
…he style or the class of the slotted element
peterpeterparker
added a commit
that referenced
this issue
Aug 10, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 10, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 11, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 13, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 13, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 13, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 14, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 14, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 14, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 14, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 14, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 15, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 15, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 15, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 15, 2019
peterpeterparker
added a commit
that referenced
this issue
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Web Component
@deckdeckgo/core
Description
When a slide is set to be revealed (
@Prop() reveal: boolean = false;
set totrue
) all its children will be revealed one after the other when the next or previous action is triggered (on desktop with keyboard or buttons, on mobile only with buttons).Currently, this is performed while modifying the
style
of the slotted elements. It works fine but this is a "no go" for our editor as we are saving the content into database respectively revealing elements would triggers a save each time an element is displayed or hide.Therefore this effect should be improved to obfuscate the action aka reveal should happens without exposing the modifications in the DOM.
Solution
Honestly I'm yet not sure how to solve this. Could it be solved without touching the DOM? Keeping references in memory?
Or maybe it has to be solved with a new shadowed Web Component (a "container") which could then obfuscate the effect but that would mean that the reveal action could only be performed if it would be used for the slotted elements?
Not sure if that's a good solution. Pro is that it would maybe offers more flexibility (see "Extra" here after).
Also not super fan of it as it would kind of be a breaking change in our upcoming editor so difficult to unleash after start...
Tech info
hideRevealElements currently hide the elements
showRevealElements currently show the elements
Extra
There is also another feature requests regarding the subject "reveal" which suggest to make the action more flexible respectively currently all children are revealed. Idea would be to be able to set which elements should be revealed and which elements should not be (see #198)
Get started
Interested to get involved and to try to resolve this issue? Ping me if you have any questions or need help to get started, David (@peterpeterparker or twitter.com/daviddalbusco) 😃
The text was updated successfully, but these errors were encountered: