-
-
Notifications
You must be signed in to change notification settings - Fork 184
[core] Handle Youtube short URL #204
Comments
I am interested to work in this issue. Can this be assigned to me? I have a confusion. By short url do you mean for ex |
Super cool 👍 Exactly, I mean the "https://youtu.be/e63Cgln6Yag" for short Url, sorry for not having described that correctly Currently:
Goal:
|
There are some packages on npm which do this for you Eg: https://github.com/nodeca/url-unshort |
@adityarb88 it would, but actually I rather like to have agnostic components, specially in the case of our core component, when possible. It's a bit more challenging but it's interesting to develop and sometimes more performant (in terms of not having to fetch extra unused codes) |
@peterpeterparker how to get started with this project? |
@bokaderohit98 what do you mean, generally speaking or regarding this issue? |
@bokaderohit98 this project is a monorepo containing, when it comes to the frontend, multiple web components and apps. once cloned, go in the (sub)projects which interest you, install the decencies ( |
@peterpeterparker i have raised a pr for this issue. #207 |
@bokaderohit98 thx 👍 P.S.: @silvererudite Rohit was super fast to provide a PR, hope it's ok for you. if you would like to try to resolve another one, it would be my pleasure. ping me |
Description
Urls provided to the slide Youtube, for example when video Url are copied/pasted from the browser bar, are formatted automatically in order to be able to render the video (embedding Youtube video is only possible if the url is passed with a specific format).
Currently, if a short Youtube Url is used, it won't be automatically formatted, as the support for that kind of source Url is not yet implemented.
Therefore, it would be great to enhance the
deckgo-youtube
component to also parse automatically such Urls.Side note
Short Url are used when web social share is used on mobile, that's why this improvement would be really appreciated.
Tech info
The component Youtube finds place in
webcomponents/core/extra
and is calleddeckgo-youtube
.The improvement should most probably be implemented in a method called formatSrc().
Get started
Interested to get involved and to try to resolve this issue? Ping me if you have any questions or need help to get started, David (@peterpeterparker or twitter.com/daviddalbusco) 😃
The text was updated successfully, but these errors were encountered: