Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

[highlight-code] display optionally line numbers #115

Closed
peterpeterparker opened this issue May 14, 2019 · 2 comments
Closed

[highlight-code] display optionally line numbers #115

peterpeterparker opened this issue May 14, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component
Milestone
studio-beta.1

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented May 14, 2019 •
edited
Loading

Description

Moreover than being able to highlight specific rows when using the code component (which is already implemented) it would be interesting to have an option to display automatically the line number at the begin of each row

0. export class Something() {
1.
2.    const hello: string = 'Yolo';
3. }

Tech info

The highlight-component finds place in webcomponents/highlight-code/. This feature should probably be implemented in the same way as the addHighlight() function.

Get started

Interested to get involved and to try to implement this feature? Ping me if you have any questions or need help to get started, David (@peterpeterparker or twitter.com/daviddalbusco) 😃
@peterpeterparker peterpeterparker added enhancement New feature or request highlight-code Highlight code web component labels May 14, 2019
@peterpeterparker peterpeterparker self-assigned this May 14, 2019
@peterpeterparker peterpeterparker changed the title Add an option display a line number at the begin of each slides in the code component Add an option display a line number at the begin of each lines in the code component May 14, 2019
@peterpeterparker peterpeterparker added the good first issue Good for newcomers label Jul 25, 2019
@peterpeterparker peterpeterparker removed their assignment Jul 25, 2019
@peterpeterparker peterpeterparker changed the title Add an option display a line number at the begin of each lines in the code component [code] Add an option display a line number at the begin of each lines in the code component Jul 25, 2019
@peterpeterparker peterpeterparker changed the title [code] Add an option display a line number at the begin of each lines in the code component [highlight-code] Add an option display a line number at the begin of each lines in the code component Jul 25, 2019
@peterpeterparker peterpeterparker changed the title [highlight-code] Add an option display a line number at the begin of each lines in the code component [highlight-code] display optionally line numbers Jul 26, 2019
@peterpeterparker
Copy link
Contributor Author

peterpeterparker commented Jul 26, 2019 •
edited
Loading

@StefanNieuwenhuis will give a try 👍

@StefanNieuwenhuis StefanNieuwenhuis mentioned this issue Jul 29, 2019
Merged
peterpeterparker added a commit that referenced this issue Jul 30, 2019
@peterpeterparker
feat(#115): reflect lineNumbers to attributes for studio and default …
92998a8 
…value to false
peterpeterparker added a commit that referenced this issue Jul 30, 2019
@peterpeterparker
doc(#115): add lineNumbers attribute to documentation
8b0f0b3
@peterpeterparker
Copy link
Contributor Author

@StefanNieuwenhuis solved this feature and an update of the component has been published to npmjs 👍

@peterpeterparker peterpeterparker added this to the studio milestone Jul 30, 2019
peterpeterparker added a commit that referenced this issue Jul 30, 2019
@peterpeterparker
feat(#115): on lineNumbers attribute change, refresh code
010234b
peterpeterparker added a commit that referenced this issue Jul 30, 2019
@peterpeterparker
feat(#115): only one lineNumbers css variable
35a868a
peterpeterparker added a commit that referenced this issue Jul 30, 2019
@peterpeterparker
feat(#115): add lineNumbers option to studio
0cc1277
peterpeterparker added a commit that referenced this issue Jul 30, 2019
@peterpeterparker
feat(#115): lineNumbers background inherit and fix highlight last lin…
28104d8 
…e height
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers highlight-code Highlight code web component
Projects
None yet
Milestone
studio-beta.1
Development

No branches or pull requests
1 participant
@peterpeterparker