Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Commit

Permalink
Merge pull request #598 from deckgo/slide-to-title-question
Browse files Browse the repository at this point in the history
fix: add poll question to list of slides on "jump to slide"
  • Loading branch information
peterpeterparker authored Jan 20, 2020
2 parents 7fd6d97 + a7e4465 commit 6968080
Show file tree
Hide file tree
Showing 9 changed files with 179 additions and 160 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

### Others
* cloud: v1.0.0-rc.3-1 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/cloud/CHANGELOG.md))
* deck-utils: v1.0.0-rc.2-2 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/utils/deck/CHANGELOG.md))
* deck-utils: v1.0.0-rc.2-3 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/utils/deck/CHANGELOG.md))
* starter kit: v1.0.0-rc.6-8 ([CHANGELOG](https://github.com/deckgo/deckdeckgo-starter/blob/master/CHANGELOG.md))

<a name="1.0.0-rc.19"></a>
Expand Down
8 changes: 4 additions & 4 deletions remote/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion remote/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dependencies": {
"@deckdeckgo/charts": "^1.0.0-rc.6",
"@deckdeckgo/core": "^1.0.0-rc.3-5",
"@deckdeckgo/deck-utils": "^1.0.0-rc.2-2",
"@deckdeckgo/deck-utils": "^1.0.0-rc.2-3",
"@deckdeckgo/highlight-code": "^1.0.0-rc.2-1",
"@deckdeckgo/lazy-img": "^1.0.0-rc.3",
"@deckdeckgo/qrcode": "^1.0.0-rc.1-1",
Expand Down
304 changes: 159 additions & 145 deletions studio/package-lock.json

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions studio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"dependencies": {
"@deckdeckgo/charts": "^1.0.0-rc.6",
"@deckdeckgo/color": "^1.0.0-rc.3-3",
"@deckdeckgo/core": "^1.0.0-rc.3-4",
"@deckdeckgo/deck-utils": "^1.0.0-rc.2-2",
"@deckdeckgo/core": "^1.0.0-rc.3-5",
"@deckdeckgo/deck-utils": "^1.0.0-rc.2-3",
"@deckdeckgo/highlight-code": "^1.0.0-rc.2-1",
"@deckdeckgo/inline-editor": "^1.0.0-rc.3-3",
"@deckdeckgo/lazy-img": "^1.0.0-rc.3",
Expand All @@ -36,12 +36,12 @@
"@deckdeckgo/social": "^1.0.0-rc.1-3",
"@deckdeckgo/utils": "^1.0.0-rc.1-4",
"@deckdeckgo/youtube": "^1.0.0-rc.1-2",
"@ionic/core": "4.11.7",
"firebase": "^7.6.2",
"@ionic/core": "4.11.8",
"firebase": "^7.7.0",
"idb-keyval": "^3.2.0",
"rxjs": "^6.5.4",
"socket.io-client": "^2.3.0",
"uuid": "^3.3.3",
"uuid": "^3.4.0",
"web-social-share": "^6.2.0"
},
"devDependencies": {
Expand All @@ -52,7 +52,7 @@
"@stencil/sass": "^1.1.1",
"@types/socket.io-client": "^1.4.32",
"@types/uuid": "^3.4.6",
"autoprefixer": "^9.7.3",
"autoprefixer": "^9.7.4",
"workbox-build": "4.3.1"
},
"repository": {
Expand Down
5 changes: 5 additions & 0 deletions utils/deck/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
<a name="1.0.0-rc.2-3"></a>
# 1.0.0-rc.2-3 (2020-01-20)

* add slide poll question to list of slides titles

<a name="1.0.0-rc.2-2"></a>
# 1.0.0-rc.2-2 (2020-01-16)

Expand Down
2 changes: 1 addition & 1 deletion utils/deck/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion utils/deck/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@deckdeckgo/deck-utils",
"version": "1.0.0-rc.2-2",
"version": "1.0.0-rc.2-3",
"author": "David Dal Busco",
"description": "Utils and styles for the DeckDeckGo applications",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion utils/deck/src/utils/slides.utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function findSlidesTitle(): Promise<string[]> {
if (slides) {
for (const slide of Array.from(slides)) {
if (slide.tagName && slide.tagName.toLowerCase().indexOf('deckgo-slide') > -1) {
const title: HTMLElement | null = slide.querySelector('[slot="title"]');
const title: HTMLElement | null = slide.querySelector('[slot="title"],[slot="question"]');

if (title && title.textContent && title.textContent !== '') {
results.push(title.textContent);
Expand Down

0 comments on commit 6968080

Please sign in to comment.