Fix processes count in processes group title cell #9087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
added
module: participatory processes
type: fix
ahukkanen
reviewed
Mar 24, 2022
...atory_processes/app/cells/decidim/participatory_process_groups/content_blocks/title/show.erb
Outdated
Show resolved
Hide resolved
ahukkanen
approved these changes
Apr 6, 2022
entantoencuanto
added a commit
to PopulateTools/decidim
that referenced
this pull request
Apr 6, 2022
…into pwa-staging * chore/cache_highligted_resources_for_components_cells: Define expiry_time on highlighted_results_for_component cell Refactor expiration time of cells cache Cache cells used view hooks defined for participatory processes Do not send upcoming meeting notification for hidden or withdrawn meetings (decidim#9134) Fix processes count in processes group title cell (decidim#9087) Fix attachments when called from Cells (decidim#9136) Clarify message to user when checking census (decidim#9112)
entantoencuanto
added a commit
that referenced
this pull request
Apr 7, 2022
* develop: Compile SCSS through sass-embedded (#9081) Prevent race condition between prevenTimeout and show modal (#9092) Bump elections dependencies to 0.23.0 (#9140) Reduce d3 bundle size (#9034) Improve wording when casting your vote (#9098) Do not send upcoming meeting notification for hidden or withdrawn meetings (#9134) Fix processes count in processes group title cell (#9087) Fix attachments when called from Cells (#9136) Clarify message to user when checking census (#9112)
andreslucena
added a commit
that referenced
this pull request
May 6, 2022
* Fix processes count in processes group title cell * Split columns 50/50
ahukkanen
pushed a commit
that referenced
this pull request
May 10, 2022
Merged
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
On some locales (for instance, French) a line was shown in two lines, breaking a bit the design.
This PR fixes it.
All the credits go to @sdelcroix as I only applied it, but the bug and the fix was provided by they.
📌 Related Issues
Testing
Go to a processes groups with multiple processes in the FR locale
📷 Screenshots
(I cheated and didn't change the locale, as it was just too much work)
Before
After