Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did-core maintenance change base58 to multibase #47

Closed
manicprogrammer opened this issue May 27, 2021 · 3 comments
Closed

did-core maintenance change base58 to multibase #47

manicprogrammer opened this issue May 27, 2021 · 3 comments
Assignees

Comments

@manicprogrammer
Copy link
Collaborator

manicprogrammer commented May 27, 2021

per commit 47909f6 in the did-core repo publickeybase58 has been changed to publickeymultibase. Adjust the entities accordingly. This should involve:

Add:

  • publickeymultibase entity and connections

Delete:

  • base58 connection from did-core

Note: base58 is also currently a depends connection from did-method-peer. Check did-method-peer to see if it still relies on base58. This may be a non-issue when referencing this issue with issue #46 as when did-method-peer is moved to non-core in #46 it's connections will be removed and it will be made the end of the chain of connections.

@manicprogrammer manicprogrammer self-assigned this May 27, 2021
@manicprogrammer
Copy link
Collaborator Author

#46 was applied prior to this issue thus the remove of the base58 connection will leave base58 orphaned and thus to be a deleted entity as part of this issue.

@manicprogrammer
Copy link
Collaborator Author

multibase was already a references connection from did-core. To fulfill this issue only Base58 entity and connection needed removed.

manicprogrammer added a commit that referenced this issue May 27, 2021
#47 did-core maintenance change base58 to multibase
@manicprogrammer
Copy link
Collaborator Author

published to v1.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant