-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove space between buttons v3 #5729
Remove space between buttons v3 #5729
Conversation
The failing build seems to be a network error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bradystroud!
I haven't tested it yet, but added a few comments on the code
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
Thanks @erezrokah, removed the unnecessary fragments in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @taineriley1 and sorry for the late review.
Added a few comments.
Also, during my tests I noticed the Save
notification hides the delete
button.
I'll check if we can move it a bit down.
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
packages/netlify-cms-core/src/components/Editor/EditorToolbar.js
Outdated
Show resolved
Hide resolved
Hi @erezrokah, Thanks for the suggestions. I have implemented this in the latest commits and the code is much more readable now. Thanks, |
Summary
Closes #5555
This PR attempts to implement the same changes as #5585 and #5685
I have moved the dropdowns from the right of the toolbar to the left.
I have also moved the 'delete' button to always be on the end.
Test plan
Tested locally in simple and editorial workflow.
Yarn test and cypress tests pass.
Checklist
Please add a
x
inside each checkbox:yarn format
.yarn test
.A picture of a cute animal (not mandatory but encouraged)